Don't compare types with equals #401
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrytz
pushed a commit
to scalacommunitybuild/utest
that referenced
this pull request
Aug 29, 2025
cherry-pick of com-lihaoyi#401
lrytz
added a commit
to scala/community-build
that referenced
this pull request
Aug 29, 2025
To include com-lihaoyi/utest#401 and com-lihaoyi/cask#172 See #1732
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed because the annotation type does not arrive dealiased in 2.13.17.
Almost ran the test suite against latest Scala but I must juggle JVM versions. I'll update if it doesn't verify the fix. (Edit: verified with JVM 8, with Scala 2 published as 2.13.16. I noticed that if I apply the edit and re-run
I must git clean for it to pass.)
Fixes #397