-
Notifications
You must be signed in to change notification settings - Fork 0
Nimbus - Data table - fix interactive columns against horizontal scroll #411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…d remove unused detailsButton slot
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…roved usability and responsiveness
…ta-slot attributes for improved accessibility
…cell background handling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a look in storybook and was able to pin rows and horizontal-scroll without issues. The UI stayed in place and the overall process appears frictionless to me. Only thing I noticed is that the sorting does not affect the pinned items, but I dunno if that is an issue at all.
At some point I'd love to go with you through the recipe and see if we can slim it down, but that can wait.
@misama-ct Thank you for taking a thorough look! Yes this is how it works at the MC current implementation and i think that is deliberate since the user wants to isolate pinned items from the rest of the table behaviour. |
@ddouglasz This is definitely an improvement and looks good to me. One question I have is whether we ever intend to also let users pin columns? |
How to test:
Result: these 3 buttons should always stay fixed when the table is scrolled horizontally.