Skip to content

Conversation

ddouglasz
Copy link
Contributor

@ddouglasz ddouglasz commented Sep 5, 2025

  • The selection checkbox buttons of the data table, along with the collapsible button and the pin row buttons currently scroll along with the data table. These three columns should be fixed while scrolling horizontally. they should always remain in their position while the rest of the table columns scroll horizontally.
  • Make the pin rows feature of the Data table sticky and always visible without it scrolling out of view.
  • Fix pin hover effect that somehow stopped worked.
  • Use the opportunity to clean up unused leftover code.

How to test:

  • Go to the all features story
  • Enable `Show all columns"
  • Enable Text truncation for a simplified ui.
  • Interact with the select, expand and pin buttons, and also scroll the table horizontally.

Result: these 3 buttons should always stay fixed when the table is scrolled horizontally.

Copy link

changeset-bot bot commented Sep 5, 2025

⚠️ No Changeset found

Latest commit: 71f4000

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Sep 5, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
nimbus-documentation Ready Ready Preview Comment Sep 19, 2025 0:33am
nimbus-storybook Ready Ready Preview Comment Sep 19, 2025 0:33am

@ddouglasz ddouglasz self-assigned this Sep 5, 2025
@ddouglasz ddouglasz marked this pull request as draft September 5, 2025 14:26
@ddouglasz ddouglasz changed the title refactor(data-table): streamline pin-row-cell styling to be sticky Nimbus - Data table - fix action rows against horizontal scroll Sep 11, 2025
…ta-slot attributes for improved accessibility
@ddouglasz ddouglasz changed the title Nimbus - Data table - fix action rows against horizontal scroll Nimbus - Data table - fix interactive columns against horizontal scroll Sep 19, 2025
Copy link
Collaborator

@misama-ct misama-ct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a look in storybook and was able to pin rows and horizontal-scroll without issues. The UI stayed in place and the overall process appears frictionless to me. Only thing I noticed is that the sorting does not affect the pinned items, but I dunno if that is an issue at all.

At some point I'd love to go with you through the recipe and see if we can slim it down, but that can wait.

@misama-ct misama-ct requested review from a team, stephsprinkle, jaikamat, valoriecarli and tylermorrisford and removed request for a team September 19, 2025 13:01
@ddouglasz
Copy link
Contributor Author

Only thing I noticed is that the sorting does not affect the pinned items

@misama-ct Thank you for taking a thorough look! Yes this is how it works at the MC current implementation and i think that is deliberate since the user wants to isolate pinned items from the rest of the table behaviour.

@ddouglasz ddouglasz merged commit 7d706ba into main Sep 19, 2025
8 checks passed
@ddouglasz ddouglasz deleted the de-nimbus-data-table-sticky-column branch September 19, 2025 14:23
@ByronDWall
Copy link
Contributor

@ddouglasz This is definitely an improvement and looks good to me.

One question I have is whether we ever intend to also let users pin columns?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants