-
Notifications
You must be signed in to change notification settings - Fork 0
ci(changesets): version packages #560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
515cee9 to
dc8d784
Compare
|
Deployment failed with the following error: |
dc8d784 to
6904ead
Compare
6904ead to
f7014de
Compare
f7014de to
333568b
Compare
333568b to
5af7cf1
Compare
5af7cf1 to
553abd7
Compare
553abd7 to
2d18d9a
Compare
2d18d9a to
7316f86
Compare
Release PR Review: Version 3.0.0This release PR consolidates three changesets into a major version bump. Overall, the changes look solid and follow proper semantic versioning practices given the breaking changes introduced. Summary of ChangesMajor Changes (Breaking)
Minor Change
Detailed Analysis1. Peer Dependencies Migration (PR #547)Impact: BREAKING CHANGE The migration of slate packages from bundled dependencies to peer dependencies is the right architectural decision: Benefits:
Concerns & Recommendations:
2. IntlProvider Integration (PR #563)Impact: Minor (non-breaking, additive) Developer experience improvement that simplifies setup for consumers. Well-executed additive change. 3. Patterns Directory Entrypoint (PR #577)Impact: Patch (non-breaking) Small but useful improvement for tree-shaking and selective imports. Testing & QualityConsider adding:
Documentation RequirementsCritical Gaps:
Security & PerformancePositive: Moving to peer dependencies gives consumers control over security updates and significantly reduces bundle size for applications already using slate. Release Readiness Checklist
Recommendation: APPROVE with Documentation RequirementsOverall Assessment: Approve to Merge with follow-up documentation work This is a solid release that makes important architectural improvements. The breaking changes are justified and well-executed technically. Strongly Recommended After Merge:
Great work on this release! The architectural improvements will benefit the project long-term. |
fe5ca4e to
1ca8bbb
Compare
fda308f to
2f5d672
Compare
2f5d672 to
4ffbe6b
Compare
4ffbe6b to
4b80c08
Compare
4b80c08 to
dca5363
Compare
dca5363 to
388930f
Compare
388930f to
4923f0c
Compare
4923f0c to
237a0af
Compare
237a0af to
d06afd0
Compare
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@commercetools/[email protected]
Minor Changes
#531
3312d94Thanks @ddouglasz! - implement data table
manager design and functionality.
#563
5cc6790Thanks @valoriecarli! - Add IntlProvider to
NimbusProvider
#547
205af3aThanks @ByronDWall! - Stop packaging slate,
slate-hyperscript, slate-history, and slate-react in nimbus directly, and
specify them as peer dependencies instead
#520
77ee9f2Thanks @valoriecarli! - Added a
TextInputField pattern component - a pre-composed field that integrates
TextInput with FormField for common use cases.
Patch Changes
#577
f83b57fThanks @ByronDWall! - Add patterns directory
to package entrypoint
#579
ef90e9cThanks @ByronDWall! - Fixes bug in
DraggableList where list does not update when external items array changes
#536
29cc2d7Thanks @misama-ct! - Introduce grouped props
tables and enhanced JSDoc documentation system
#620
7e31d53Thanks @misama-ct! - removed unnecessary
tabIndex property from Card
#598
bc4a92eThanks @ByronDWall! - TextInput now consumes
react-aria's InputContext, Button consumes isDisabled from context
#636
3caf3edThanks @tylermorrisford! - Introduces
the date-range-picker-field as a composed, happy-path component.
#637
53882a2Thanks @tylermorrisford! - Update
changeset configuration to prevent unnecessary major version bumps
#643
42124ceThanks @tylermorrisford! - Changes the
designated changeset github action and includes the PR title in the release
workflow.
Updated dependencies
[
42124ce]:@commercetools/[email protected]
Patch Changes
42124ceThanks @tylermorrisford! - Changes the
designated changeset github action and includes the PR title in the release
workflow.
@commercetools/[email protected]
Patch Changes
42124ceThanks @tylermorrisford! - Changes the
designated changeset github action and includes the PR title in the release
workflow.
@commercetools/[email protected]
Patch Changes
42124ceThanks @tylermorrisford! - Changes the
designated changeset github action and includes the PR title in the release
workflow.