Skip to content

Conversation

@ct-changesets
Copy link
Contributor

@ct-changesets ct-changesets bot commented Oct 20, 2025

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@commercetools/[email protected]

Minor Changes

  • #531
    3312d94
    Thanks @ddouglasz! - implement data table
    manager design and functionality.

  • #563
    5cc6790
    Thanks @valoriecarli! - Add IntlProvider to
    NimbusProvider

  • #547
    205af3a
    Thanks @ByronDWall! - Stop packaging slate,
    slate-hyperscript, slate-history, and slate-react in nimbus directly, and
    specify them as peer dependencies instead

  • #520
    77ee9f2
    Thanks @valoriecarli! - Added a
    TextInputField pattern component - a pre-composed field that integrates
    TextInput with FormField for common use cases.

Patch Changes

@commercetools/[email protected]

Patch Changes

  • #643
    42124ce
    Thanks @tylermorrisford! - Changes the
    designated changeset github action and includes the PR title in the release
    workflow.

@commercetools/[email protected]

Patch Changes

  • #643
    42124ce
    Thanks @tylermorrisford! - Changes the
    designated changeset github action and includes the PR title in the release
    workflow.

@commercetools/[email protected]

Patch Changes

  • #643
    42124ce
    Thanks @tylermorrisford! - Changes the
    designated changeset github action and includes the PR title in the release
    workflow.

@vercel
Copy link

vercel bot commented Oct 20, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
nimbus-documentation Ready Ready Preview Comment Oct 31, 2025 7:01pm
nimbus-storybook Ready Ready Preview Comment Oct 31, 2025 7:01pm

@vercel
Copy link

vercel bot commented Oct 20, 2025

Deployment failed with the following error:

Failed to create deployment for team_2p5rIhVqKRQrDrj1AEggz8vt in project prj_fngOCfQIskwv1uBxMO3GcHEKcVxk: FetchError: request to https://76.76.21.112/v13/now/deployments?ownerId=team_2p5rIhVqKRQrDrj1AEggz8vt&projectId=prj_fngOCfQIskwv1uBxMO3GcHEKcVxk&skipAutoDetectionConfirmation=1&teamId=team_2p5rIhVqKRQrDrj1AEggz8vt&traceCarrier=%7B%22ot-baggage-webhookAt%22%3A%221760989887457%22%2C%22ot-baggage-senderUsername%22%3A%22gh.ct-changesets%5Bbot%5D%22%2C%22baggage%22%3A%22webhookAt%3D1760989887457%2CsenderUsername%3Dgh.ct-changesets%255Bbot%255D%22%2C%22x-datadog-trace-id%22%3A%221614690062364816075%22%2C%22x-datadog-parent-id%22%3A%226891327833582737095%22%2C%22x-datadog-sampling-priority%22%3A%222%22%2C%22x-datadog-tags%22%3A%22_dd.p.tid%3D68f692bf00000000%2C_dd.p.dm%3D-3%22%2C%22traceparent%22%3A%2200-68f692bf000000001668880e859bb2cb-5fa2ea271f7616c7-01%22%2C%22tracestate%22%3A%22dd%3Dt.tid%3A68f692bf00000000%3Bt.dm%3A-3%3Bs%3A2%3Bp%3A5fa2ea271f7616c7%22%7D failed, reason: socket hang up

@ct-changesets ct-changesets bot force-pushed the changeset-release/main branch from dc8d784 to 6904ead Compare October 21, 2025 13:09
@ct-changesets ct-changesets bot force-pushed the changeset-release/main branch from 6904ead to f7014de Compare October 21, 2025 17:33
@ct-changesets ct-changesets bot force-pushed the changeset-release/main branch from f7014de to 333568b Compare October 21, 2025 19:20
@ct-changesets ct-changesets bot force-pushed the changeset-release/main branch from 333568b to 5af7cf1 Compare October 22, 2025 05:52
@ct-changesets ct-changesets bot force-pushed the changeset-release/main branch from 5af7cf1 to 553abd7 Compare October 22, 2025 16:13
@ct-changesets ct-changesets bot force-pushed the changeset-release/main branch from 553abd7 to 2d18d9a Compare October 22, 2025 19:20
@ct-changesets ct-changesets bot force-pushed the changeset-release/main branch from 2d18d9a to 7316f86 Compare October 23, 2025 09:54
@claude
Copy link

claude bot commented Oct 23, 2025

Release PR Review: Version 3.0.0

This release PR consolidates three changesets into a major version bump. Overall, the changes look solid and follow proper semantic versioning practices given the breaking changes introduced.


Summary of Changes

Major Changes (Breaking)

  1. PR CRAFT-1770- Relocate IntlProvider #563: IntlProvider integration into NimbusProvider
  2. PR CRAFT 1815 | import components from @commercetools/nimbus namespace in story files #547: Slate and related packages moved to peer dependencies

Minor Change

  1. PR CRAFT 1824 | add patterns to entrypoint chunks in vite.config.ts #577: Pattern directory added to package entrypoints

Detailed Analysis

1. Peer Dependencies Migration (PR #547)

Impact: BREAKING CHANGE

The migration of slate packages from bundled dependencies to peer dependencies is the right architectural decision:

Benefits:

  • Prevents multiple instances of slate/react-aria in consuming applications
  • Reduces bundle size for consumers who already have these packages
  • Follows React ecosystem best practices (similar to React itself)
  • Gives consumers control over exact versions

Concerns & Recommendations:

  1. Documentation Gap: The CHANGELOG should include a migration guide for consumers
  2. Version Ranges: Peer dependencies use specific versions - document version compatibility
  3. react-intl: Now also a peer dependency (7.x) - should be highlighted in migration notes

2. IntlProvider Integration (PR #563)

Impact: Minor (non-breaking, additive)

Developer experience improvement that simplifies setup for consumers. Well-executed additive change.

3. Patterns Directory Entrypoint (PR #577)

Impact: Patch (non-breaking)

Small but useful improvement for tree-shaking and selective imports.


Testing & Quality

Consider adding:

  1. Integration Tests for peer dependency scenarios
  2. Backward Compatibility tests for consumers upgrading from 2.x

Documentation Requirements

Critical Gaps:

  1. Migration Guide (HIGH PRIORITY): Create MIGRATION-3.0.md with peer dependency installation steps
  2. Version Compatibility Matrix: Document tested peer dependency versions

Security & Performance

Positive: Moving to peer dependencies gives consumers control over security updates and significantly reduces bundle size for applications already using slate.


Release Readiness Checklist

  • Version bumps are correct (3.0.0 across all packages)
  • CHANGELOG entries are present
  • Breaking changes are documented in changesets
  • MISSING: Migration guide for consumers
  • MISSING: Peer dependency version compatibility matrix
  • All dependent packages bumped together

Recommendation: APPROVE with Documentation Requirements

Overall Assessment: Approve to Merge with follow-up documentation work

This is a solid release that makes important architectural improvements. The breaking changes are justified and well-executed technically.

Strongly Recommended After Merge:

  1. Create migration guide documentation (can be a follow-up PR)
  2. Update README with peer dependency information
  3. Consider adding integration tests for peer dependency scenarios

Great work on this release! The architectural improvements will benefit the project long-term.

@stephsprinkle stephsprinkle merged commit 9f4bb4b into main Nov 3, 2025
10 checks passed
@stephsprinkle stephsprinkle deleted the changeset-release/main branch November 3, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants