Comfyui

[jdacode]

🛑 New scripts must first be submitted to ProxmoxVED for testing.
PRs for new scripts that skip this process will be closed.

---

✍️ Description

Adds ComfyUI LXC Script

🔗 Related PR / Issue

Link: community-scripts/ProxmoxVE#3915

✅ Prerequisites (X in brackets)

• Self-review completed – Code follows project standards.
• Tested thoroughly – Changes work as expected.
• No breaking changes – Existing functionality remains intact.
• No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

---

🛠️ Type of Change (X in brackets)

• 🐞 Bug fix – Resolves an issue without breaking functionality.
• ✨ New feature – Adds new, non-breaking functionality.
• 💥 Breaking change – Alters existing functionality in a way that may require updates.
• 🆕 New script – A fully functional and tested script or script set.
• 🌍 Website update – Changes to website-related JSON files or metadata.
• 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
• 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

---

🔍 Code & Security Review (X in brackets)

• Follows Code_Audit.md & CONTRIBUTING.md guidelines
• Uses correct script structure (AppName.sh, AppName-install.sh, AppName.json)
• No hardcoded credentials

📋 Additional Information (optional)

[MickLesk]

Stick to the guidelines of other scripts. Not a single one has split everything into subfunctions.

We have many helper functions that simply remove many lines. Take a look at the current scripts in the live repo. It's not worth evaluating the script here, as I would basically have to criticize every line of intall.sh.

[jdacode]

Thanks MickLesk for your prompt response. I'm happy to reduce the script. I couldn’t find anything in the guidelines about avoiding subfunctions, just curious if there's a specific reason for not using them?. Also, is there a maximum line count limit we should follow?

[CrazyWolf13]

@jdacode please follow the guidelines like everyone else does: https://github.com/community-scripts/ProxmoxVE/wiki/CONTRIBUTING

We want our scripts to follow the standarts so it's easier to maintain them.

[jdacode]

Yeah, very sorry about that

[jdacode]

I did some changes, happy to make more if needed 🙂

[jdacode]

Do you guys accept dynamic variables in the install.sh script, such as:

python_version_uv=${python_version_uv:-3.12}

So this allows users to modify installation parameters

[tremor021]

Remove all comments except header ones

[MickLesk]

Do you guys accept dynamic variables in the install.sh script, such as:

python_version_uv=${python_version_uv:-3.12}

So this allows users to modify installation parameters

In the current Case the most of this will be ignored, because install.sh is an subshell execution inside the lxc

[jdacode]

I made some changes to the code:

• Removed the comments
• Added the fetch_and_deploy_gh_release function
• Ensured it only uses the latest version

@MickLesk thanks for responding. I was referring more to the case where users want to modify some parameters before bash command, for example:

comfyui_python_version_uv="3.12" bash -c "$(curl -fsSL https://.../ct/comfyui.sh)"

I think this is super useful. However, I'm happy to remove the dynamic variables from the script if you guys want

[michelroegl-brunner]

So. You can remove all of your variables
you have in there. The call as you imagine it will not work. You call the ct.sh file, wich calls build.func wich then calls install-ct.sh. Your variables will not get passed allong.

Also shorten the user input dialouges.

[jdacode]

Hey @michelroegl-brunner thanks for your input.

I either removed the variable or changed it to a local one. I also removed or shortened some of the dialogs. Let me know if theres anything else to change.