Skip to content

Conversation

@JohanMabille
Copy link
Collaborator

Currently, executing xcpp::display(33) outputs the adress of the variable instead of its value. This PR fixes this error.

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.94%. Comparing base (6117076) to head (557681f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #398      +/-   ##
==========================================
+ Coverage   81.77%   81.94%   +0.17%     
==========================================
  Files          20       21       +1     
  Lines         845      853       +8     
  Branches       87       87              
==========================================
+ Hits          691      699       +8     
  Misses        154      154              
Files with missing lines Coverage Δ
include/xcpp/xmime.hpp 100.00% <100.00%> (ø)
Files with missing lines Coverage Δ
include/xcpp/xmime.hpp 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Collaborator

@anutosh491 anutosh491 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (just needs a test I think)

@mcbarton
Copy link
Collaborator

Looks good (just needs a test I think)

I also agree that it needs a test, given its fixing a particular bug.

@JohanMabille JohanMabille force-pushed the display branch 2 times, most recently from d0b9f7d to 2122ff8 Compare October 24, 2025 07:00
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@anutosh491
Copy link
Collaborator

anutosh491 commented Oct 24, 2025

Hmm the emscripten test added passes

/home/runner/work/xeus-cpp/xeus-cpp/test/test_interpreter.cpp:1086:
TEST SUITE: mime_bundle_repr
TEST CASE:  int
/home/runner/work/xeus-cpp/xeus-cpp/test/test_interpreter.cpp:1094: SUCCESS: REQUIRE( res == expected ) is correct!
  values: REQUIRE( {"text/plain":"42"} == {"text/plain":"42"} )

Probably something else fails. Having a look !

@anutosh491
Copy link
Collaborator

anutosh491 commented Oct 24, 2025

Probably something else fails. Having a look !

Looks like a random crash.
CI uses node 20
Locally checking with 23/24(latest) works as want, with 20 fails.

So an upgrade should just fix this (making an upgrade PR now)

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

clang-tidy review says "All clean, LGTM! 👍"

@anutosh491
Copy link
Collaborator

Ahh if we see this (https://github.com/compiler-research/xeus-cpp/actions/runs/19163170967/job/54777686023?pr=398#step:5:387) we have the following while running node test_xeus_cpp.js in both the linux/macos CI.

wasm://wasm/1033ab66:1


RuntimeError: memory access out of bounds
    at wasm://wasm/1033ab66:wasm-function[19481]:0x1c3a2fd
    at wasm://wasm/1033ab66:wasm-function[19220]:0x1c2bf57
    at wasm://wasm/1033ab66:wasm-function[329]:0x494cea
    at invoke_vii (/home/runner/work/xeus-cpp/xeus-cpp/build/test/test_xeus_cpp.js:1:776501)
    at wasm://wasm/009f3f26:wasm-function[792]:0x10f3ec
    at invoke_vii (/home/runner/work/xeus-cpp/xeus-cpp/build/test/test_xeus_cpp.js:1:776501)
    at wasm://wasm/009f3f26:wasm-function[803]:0x112e34
    at invoke_vii (/home/runner/work/xeus-cpp/xeus-cpp/build/test/test_xeus_cpp.js:1:776501)
    at wasm://wasm/009f3f26:wasm-function[898]:0x128d69
    at wasm://wasm/00168dfa:wasm-function[376]:0x29774
    

Probably the same reason why the browser test fails in the macos CI.

This is a known error to me. Have dealt with this before while dealing with later node versions. Making a simple change fixing it.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

clang-tidy review says "All clean, LGTM! 👍"

@mcbarton mcbarton merged commit 9a4af34 into compiler-research:main Nov 7, 2025
18 checks passed
@JohanMabille JohanMabille deleted the display branch November 7, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants