-
Notifications
You must be signed in to change notification settings - Fork 36
Fixed default mime_bundle_repr #398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #398 +/- ##
==========================================
+ Coverage 81.77% 81.94% +0.17%
==========================================
Files 20 21 +1
Lines 845 853 +8
Branches 87 87
==========================================
+ Hits 691 699 +8
Misses 154 154
🚀 New features to boost your workflow:
|
|
clang-tidy review says "All clean, LGTM! 👍" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good (just needs a test I think)
I also agree that it needs a test, given its fixing a particular bug. |
d0b9f7d to
2122ff8
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Hmm the emscripten test added passes Probably something else fails. Having a look ! |
Looks like a random crash. So an upgrade should just fix this (making an upgrade PR now) |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Ahh if we see this (https://github.com/compiler-research/xeus-cpp/actions/runs/19163170967/job/54777686023?pr=398#step:5:387) we have the following while running Probably the same reason why the browser test fails in the macos CI. This is a known error to me. Have dealt with this before while dealing with later node versions. Making a simple change fixing it. |
|
clang-tidy review says "All clean, LGTM! 👍" |
Currently, executing
xcpp::display(33)outputs the adress of the variable instead of its value. This PR fixes this error.