Extend concat-examples support
#108
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes some duplicated instances, moves some others out of test-specific code, and adds a few others. Overall, this makes `ConCat.Circuit` and `ConCat.Syntactic` better supported under Categorifier.
Makes it easier to use the `ConCat.Syntactic` category with Categorifier. Also provides a package and pattern for adding these instances for other categories from `concat-examples`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
concat-examplescontains a number of useful categories, but they’re not quite usable by Categorifier in general.This sets up a pattern for supporting them and implements it for the
ConCat.Syntacticcategory. It defines the plugin-specific instances for them (and moves existing ones out of test-specific code) and also definesconcat-extensionsandunconcatinstances.Syntacticis a trivial category, but the pattern should work across others, which can be integrated over time.