Skip to content

Conversation

@hwse
Copy link
Contributor

@hwse hwse commented Aug 22, 2025

Summary

Changes to recipe: librdkafka/2.11.1

Motivation

latest version of librdkafka with bugfixes and features

Details

CMakeLists.txt has not changed between 2.8.0 and 2.11.1, so re-using the patches from 2.8.0


@toge
Copy link
Contributor

toge commented Aug 22, 2025

There is a bug on 2.11.1.
confluentinc/librdkafka#5135

@hwse
Copy link
Contributor Author

hwse commented Aug 22, 2025

Build is likely failing due to librdkafka issue: confluentinc/librdkafka#5136

@hwse
Copy link
Contributor Author

hwse commented Aug 22, 2025

There is a bug on 2.11.1. confluentinc/librdkafka#5135

I could add a patch with the fix for the #if WITH_OAUTHBEARER_OIDC to hopefully fix the build failure. @toge are you okay with that?

Edit: added the patch and in my local build this fixes the issue

@vanshbhardwajhere
Copy link

Hi @hwse,
I am vansh, I am just curious to know how your PR will be assigned a job scheduler can you please tell me or guide me
Cause I am a beginner in open-source contribution!
Thank you

@hwse
Copy link
Contributor Author

hwse commented Aug 24, 2025

Hi @hwse, I am vansh, I am just curious to know how your PR will be assigned a job scheduler can you please tell me or guide me Cause I am a beginner in open-source contribution! Thank you

Assuming that you mean the CI build jobs: I think they need to be approved/triggered by a maintainer of conan central.

@vanshbhardwajhere
Copy link

Hi @hwse, I am vansh, I am just curious to know how your PR will be assigned a job scheduler can you please tell me or guide me Cause I am a beginner in open-source contribution! Thank you

Assuming that you mean the CI build jobs: I think they need to be approved/triggered by a maintainer of conan central.

Thank you for you Supportive and quick response!

@hwse
Copy link
Contributor Author

hwse commented Aug 27, 2025

There is a bug on 2.11.1. confluentinc/librdkafka#5135

Hey @toge , the mentioned bug should be fixed with the patch i added in the second commit

Copy link
Contributor

@perseoGI perseoGI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM confluentinc/librdkafka@v2.8.0...v2.11.1

Diff between our last maintained release and the new one is mainly C++ code changes.

@franramirez688 franramirez688 merged commit f0da95f into conan-io:master Aug 28, 2025
9 checks passed
@vanshbhardwajhere
Copy link

@franramirez688 Nice to see that you merged this PR!
I want to ask what is the process after approval to merging because my PR #28243
was approved last week but still no updates regarding merge!
Please let me know if there is any task from my side to trigger the merge cause I am beginner to to contribution, I am not that much aware of it!
Thank you

hoyhoy pushed a commit to hoyhoy/conan-center-index that referenced this pull request Oct 10, 2025
* librdkafka 2.11.1

* librdkafka: add patch from github for build issue without curl
jeremydumais pushed a commit to jeremydumais/conan-center-index that referenced this pull request Oct 11, 2025
* librdkafka 2.11.1

* librdkafka: add patch from github for build issue without curl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants