Accepts Headers #25
Open
Accepts Headers #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Nerdenberger! Thanks for the PR. It looks like we have a mix of tabs vs spaces. Can you fix that up? |
jheth
reviewed
Aug 16, 2017
|
|
||
| @headers = options[:headers] if options[:headers] | ||
|
|
||
| @headers = { 'tns:CallOptions' => { 'tns:client' => client_id } } if client_id |
There was a problem hiding this comment.
This combination of client_id would not work with optional headers. What if you merge the hashes? @headers.merge(options[:headers]) if options[:headers].is_a?(Hash)
jheth
reviewed
Aug 16, 2017
|
|
||
| def query(soql) | ||
| call_soap_api(:query, {:queryString => soql}) | ||
| def query(soql, header={}) |
There was a problem hiding this comment.
Instead of passing header into every method I think you can use @headers in call_soap_api and it would apply to all calls. Do you ever find yourself needing different headers per request?
|
@Nerdenberger What do you think of the comments I left on the commits? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a user of the SOAP API I often need to pass headers such as 'AllOrNone' or 'AssignmentRule' to salesforce to fit the requirements of my integration.
This PR adds the ability for a user to pass an optional headers argument to most SOAP calls.