Infr 2957/refactor #248
Infr 2957/refactor #248
Conversation
|
|
There was a problem hiding this comment.
Hey @kevinyosua-krom Thanks for opening a PR, I left a few comments that needed to be fixed, also you will need to sign the CLA in order to merge the changes, and pull from master, I notice that the branch is outdated.
| bucket = var.s3_bucket_name | ||
| count = var.s3_bucket_name == null ? 0 : 1 | ||
| bucket = var.s3_bucket_name | ||
| provider = aws.bucket_s3 # Gunakan provider yang bisa akses akun lain |
There was a problem hiding this comment.
Need to remove the comment here
| aws = { | ||
| source = "hashicorp/aws" | ||
| version = ">= 5.32.0" | ||
| configuration_aliases = [aws.bucket_s3] |
There was a problem hiding this comment.
I am not sure that I understand why there is a need to add this, if you are still using the AWS provider?
| terraform-module = "eventbridge-to-coralogix" | ||
| terraform-module-version = "v0.0.3" | ||
| managed-by = "coralogix-terraform" | ||
| refactored-by = "krom-devops-team" |
There was a problem hiding this comment.
Need to remove this line, as in the end we are still the ones who maintain the module 😅
| @@ -1,10 +1,9 @@ | |||
| terraform { | |||
| required_version = ">= 1.3.0" | |||
There was a problem hiding this comment.
We keep a minimum version for the module, as it does not support an older version, so please keep this line.
4 participants
Description
Fixes #How Has This Been Tested?
Checklist: