Limit number of repos from github_user_projects #2488
Merged
+66
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some users have a vast number of repos that they own or have control over in some way, which can lead to rediculous results. We had one user where this caused a response to take 28 seconds (instead of milliseconds) and all by *itself* this request increased memory use by 457MB. This caps the number of repos we consider to a smaller reasonable number. We sort by 'updated', so the repos that are being actively maintained will be the ones returned if the cap is being used. In extreme cases like this, the expected impact of this change is: - Memory per user page view: 457MB -> ~0.2MB (99.96% reduction) - Response time: 25-28 seconds -> less than 1 second - GitHub API calls: 30-100+ -> 1 Signed-off-by: David A. Wheeler <[email protected]>
Change so we only consider public GitHub projects
('public' not 'all) when creating a list of user projects.
Signed-off-by: David A. Wheeler <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2488 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 58 58
Lines 2324 2325 +1
=========================================
+ Hits 2324 2325 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: David A. Wheeler <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: David A. Wheeler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users have a vast number of repos that they own or have control over in some way, which can lead to rediculous results. We had one user where this caused a response to take 28 seconds (instead of milliseconds) and all by itself this request increased memory use by 457MB.
This caps the number of repos we consider to a smaller reasonable number. We sort by 'updated', so
the repos that are being actively maintained will be the ones returned if the cap is being used.
In extreme cases like this, the expected impact of this change is: