filter out label with empty value in distributor #7069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeya24
force-pushed
the
filter-out-empty-label-ingester
branch
from
3c9f58a to
b516e13
Compare
|
Nice improvements |
SungJin1212
approved these changes
Oct 27, 2025
Signed-off-by: yeya24 <[email protected]>
Signed-off-by: yeya24 <[email protected]>
yeya24
force-pushed
the
filter-out-empty-label-ingester
branch
from
b516e13 to
f9674fc
Compare
|
Nice! thanks |
alanprot
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
In ingester, we are seeing about 9.2% of allocations in
labels.Labels.WithoutEmptywhen appending series to TSDB. If there is any label with empty value, a new label slice is allocated to exclude empty value labels. https://github.com/prometheus/prometheus/blob/817dde743c280f3364c5ecb127cf38a26298198c/model/labels/labels_slicelabels.go#L241This allocation is unnecessary and can cause more frequent GC. One way to improve is to filter out empty label value in the distributor to avoid more work on the Ingester hot path.
Note that filtering out empty values won't change how the series is sharded as we also filter out empty value in the sharding key. #5717
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]