Skip to content

Conversation

@mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Oct 22, 2025

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the main branch

)
return receipt
else:
return receipt

Check failure

Code scanning / CodeQL

Potentially uninitialized local variable Error test

Local variable 'receipt' may be used before it is initialized.
ref cmd

wait 2 blks
@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.20%. Comparing base (5217b59) to head (e53c5d0).

❌ Your project check has failed because the head coverage (65.20%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #753      +/-   ##
==========================================
+ Coverage   64.12%   65.20%   +1.08%     
==========================================
  Files         317      317              
  Lines       21717    21598     -119     
==========================================
+ Hits        13927    14084     +157     
+ Misses       6472     6353     -119     
+ Partials     1318     1161     -157     

see 19 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mmsqe mmsqe marked this pull request as ready for review November 6, 2025 08:50
]
).transact(w3, users[0])
await weth.fns.withdraw(amount_all).transact(w3, users[0], to=WETH_ADDRESS)
balances_bf = await multicall(w3, balances)

Check warning

Code scanning / CodeQL

Variable defined multiple times Warning test

This assignment to 'balances_bf' is unnecessary as it is
redefined
before this value is used.
t.cancel()
try:
await t
except asyncio.CancelledError:

Check notice

Code scanning / CodeQL

Empty except Note test

'except' clause does nothing but pass and there is no explanatory comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant