Dist landing page #33
Conversation
| }); | ||
|
|
||
| input.addEventListener('keyup', function () { | ||
| input.value = input.value.replace(new RegExp("([^a-zA-Z0-9\-]+)", "g"), ""); |
There was a problem hiding this comment.
You can do this without JavaScript if you'd like by using the <input pattern="..." /> HTML attribute (MDN docs). If the input doesn't pass validation, the submit event shouldn't(?) happen.
There was a problem hiding this comment.
It's just a preference, I prefer validating the input and preventing the characters this way.
| } | ||
| }; | ||
|
|
||
| let dists = [ |
There was a problem hiding this comment.
This might be better as let dists = <%= encode_json $dists %>, but that's just an opinion, not a requirement :)
| setupEvents: function () { | ||
| let self = this; | ||
| let input = self.search_form.querySelector('input#search'); | ||
| self.search_form.addEventListener('submit', function (evt) { |
There was a problem hiding this comment.
If you use arrow functions, you can get rid of the need to do let self = this;:
this.search_form.addEventListener('submit', (evt) => {
// inside here, `this` is the same as outside
});
|
Yes you can merge this without merging #34 as 34 is just a fork of this with the main changes being on the /dist/ pages. |
No description provided.