-
Notifications
You must be signed in to change notification settings - Fork 5
Add doc search #1047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Add doc search #1047
Conversation
This needs to be fixed first: boostorg/boostlook#142. Closing for now |
@mborland |
So if you run npm install it fixes the error. The resulting page is missing a search bar. The Gitlab page for the extension mentioned specific integration measures which seem style sheet specific |
"if you run npm install it fixes the error. " That's fine for a developer locally. But "npm install" doesn't generate consistent builds because the package versions alter, so it could break unexpectedly. "npm ci" keeps the same set of packages. That is what "doc previews" and "release tools" would use. Previews showed "npm ERR". |
I guess my expectation was that if the build doesn't have the search bar locally it's not going to have it once I run it through your automated build system. When I changed the UI bundle to antoras default the search bar was there (and the screenshot included in the issue) |
An automated preview of the documentation is available at https://1047.decimal.prtest3.cppalliance.org/libs/decimal/doc/html/index.html |
@sdarwin This doc preview should have the extension installed, and I think this is what needs to be added to boostlook: https://gitlab.com/antora/antora-lunr-extension#user-content-search-input |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1047 +/- ##
=========================================
+ Coverage 98.3% 98.3% +0.1%
=========================================
Files 249 251 +2
Lines 16490 16504 +14
Branches 1855 1854 -1
=========================================
+ Hits 16209 16223 +14
Misses 281 281 see 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
No description provided.