Skip to content

Conversation

mborland
Copy link
Member

No description provided.

@mborland mborland added this to the v6.0.0 milestone Sep 10, 2025
@mborland mborland self-assigned this Sep 10, 2025
@mborland mborland added the documentation Improvements or additions to documentation label Sep 10, 2025
@mborland
Copy link
Member Author

This needs to be fixed first: boostorg/boostlook#142. Closing for now

@mborland mborland closed this Sep 10, 2025
@sdarwin
Copy link
Contributor

sdarwin commented Sep 10, 2025

@mborland
To be aware, there are other issues, not only boostlook. "npm ERR! The npm ci command can only install with an existing package-lock.json". Consider a CI test in github actions or drone that runs build_antora.sh.

@mborland
Copy link
Member Author

So if you run npm install it fixes the error. The resulting page is missing a search bar. The Gitlab page for the extension mentioned specific integration measures which seem style sheet specific

@sdarwin
Copy link
Contributor

sdarwin commented Sep 10, 2025

"if you run npm install it fixes the error. " That's fine for a developer locally. But "npm install" doesn't generate consistent builds because the package versions alter, so it could break unexpectedly. "npm ci" keeps the same set of packages. That is what "doc previews" and "release tools" would use. Previews showed "npm ERR".

@mborland
Copy link
Member Author

I guess my expectation was that if the build doesn't have the search bar locally it's not going to have it once I run it through your automated build system. When I changed the UI bundle to antoras default the search bar was there (and the screenshot included in the issue)

@mborland mborland reopened this Sep 10, 2025
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://1047.decimal.prtest3.cppalliance.org/libs/decimal/doc/html/index.html

@mborland
Copy link
Member Author

@sdarwin This doc preview should have the extension installed, and search-index.js built, but there's nowhere to interact with the search.

I think this is what needs to be added to boostlook: https://gitlab.com/antora/antora-lunr-extension#user-content-search-input

Copy link

codecov bot commented Sep 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.3%. Comparing base (c993480) to head (4f415fc).
⚠️ Report is 15 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #1047     +/-   ##
=========================================
+ Coverage     98.3%   98.3%   +0.1%     
=========================================
  Files          249     251      +2     
  Lines        16490   16504     +14     
  Branches      1855    1854      -1     
=========================================
+ Hits         16209   16223     +14     
  Misses         281     281             

see 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c993480...4f415fc. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants