Skip to content

Conversation

@wysiwys
Copy link
Collaborator

@wysiwys wysiwys commented May 21, 2025

Improvements to the benchmarking interface:

  • Add option to select all/deselect all values for a given key
  • Add button to clear all filters
  • Display the current number of charts shown

Additionally, this PR removes the test-fail.yml CI workflow for failure, since it is not compatible with the new folder structure.

@wysiwys wysiwys self-assigned this May 21, 2025
@wysiwys wysiwys linked an issue May 21, 2025 that may be closed by this pull request
@wysiwys wysiwys changed the base branch from main to wysiwys/retrieve-prev-bench May 22, 2025 06:58
@wysiwys wysiwys marked this pull request as ready for review May 22, 2025 10:15
@wysiwys wysiwys requested a review from keks May 22, 2025 10:16
Copy link
Member

@keks keks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, just one nit. Let's merge this to see how this behaves in real use :)

@keks
Copy link
Member

keks commented May 22, 2025

Ah, one more question -- any reson the failure test workflow is gone?

@wysiwys
Copy link
Collaborator Author

wysiwys commented May 22, 2025

Ah, one more question -- any reson the failure test workflow is gone?

The reasoning behind the removal is that this workflow (which was triggered on PRs) made use of the gh-pages-test branch in this repo to retrieve some sample 'before' data to compare the sample 'after' data (which is slower) against. However, this workflow was no longer compatible with the new folder structure, since we would now need to retrieve the 'before' data from the file for the current PR's base branch (and sha) in this repo.

I couldn't think of a good way to work around this on CI, without enabling upload on push for all branches, so I just removed the workflow, and any other changes seemed like they would be too involved to be in scope for this PR. However, I definitely think it would make sense to find another way to test this on CI!

@wysiwys wysiwys merged commit 345bcb3 into wysiwys/retrieve-prev-bench May 22, 2025
3 checks passed
@wysiwys wysiwys deleted the wysiwys/select-all-deselect-all branch May 22, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Select/deselect all in filtering interface

2 participants