-
Notifications
You must be signed in to change notification settings - Fork 0
New features #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New features #32
Conversation
keks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good, just one nit. Let's merge this to see how this behaves in real use :)
|
Ah, one more question -- any reson the failure test workflow is gone? |
The reasoning behind the removal is that this workflow (which was triggered on PRs) made use of the I couldn't think of a good way to work around this on CI, without enabling upload on push for all branches, so I just removed the workflow, and any other changes seemed like they would be too involved to be in scope for this PR. However, I definitely think it would make sense to find another way to test this on CI! |
Improvements to the benchmarking interface:
Additionally, this PR removes the
test-fail.ymlCI workflow for failure, since it is not compatible with the new folder structure.