Skip to content

Conversation

karthikbhargavan
Copy link
Contributor

This PR improves the performance of some ML-KEM and ML-DSA proofs to help them pass on the CI machine.
There is still some work to be done here.

To measure the worst-performing functions, I use the following command on the logs generated:

cat log | sed -n 's/^[^(]*(\([^)]*)\)).*in \([0-9]*\) milliseconds .*/\2 \1/p' | sort -r -n -k1

I then addressed the top few failing queries by rewriting their proofs.

Copy link
Member

@W95Psp W95Psp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a few nits!

Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with a few nits.

Also, the said we wanted to reduce large F* blobs by moving things out. We should do that whenever we touch something. It's fine to get it in like this, but let's start improving things when touching them.

@karthikbhargavan karthikbhargavan added this pull request to the merge queue Aug 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 25, 2025
@franziskuskiefer
Copy link
Member

The C code needs updating

@karthikbhargavan karthikbhargavan added this pull request to the merge queue Aug 25, 2025
Merged via the queue into main with commit 7bf2ee9 Aug 25, 2025
93 checks passed
@karthikbhargavan karthikbhargavan deleted the ci-fix branch August 25, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants