-
Notifications
You must be signed in to change notification settings - Fork 26
Fixing proofs on CI #1114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing proofs on CI #1114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just a few nits!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with a few nits.
Also, the said we wanted to reduce large F* blobs by moving things out. We should do that whenever we touch something. It's fine to get it in like this, but let's start improving things when touching them.
The C code needs updating |
This PR improves the performance of some ML-KEM and ML-DSA proofs to help them pass on the CI machine.
There is still some work to be done here.
To measure the worst-performing functions, I use the following command on the logs generated:
I then addressed the top few failing queries by rewriting their proofs.