-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Remove internal type OAuth::Params
#16319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove internal type OAuth::Params
#16319
Conversation
|
Updated according to review: 1.Removed OAuth::Params and replaced with URI::Params All std specs are passing. |
apply suggested loop style and variable naming from review Co-authored-by: Julien Portalier <[email protected]>
straight-shoota
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few nitpicks, mostly about unnecessary stylistic changes, but also found semantic problems.
|
Hi @straight-shoota, |
ysbaddaden
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one last tidbit. Thanks for your patience with all these changes 🙇
|
Thanks @ysbaddaden
The code is now much cleaner and matches the recommended approach. |
|
Needs a crystal tool format, and that's it. |
Co-authored-by: Sijawusz Pur Rahnama <[email protected]>
OAuth::Params
The internal type OAuth::Params was redundant and used only by OAuth::Signature.
This refactor replaces it with URI::Params plus an RFC3986-compatible normalization method.
All stdlib specs pass (0 failures, 0 errors).
Fixes #16317