Visualizing schematic representation of Hillas parameters

[vuillaut]

This is an addition to the documentation to display as a schema what are the Hillas parameters:

[maxnoe]

Nice!

Does it also work in TelescopeFrame? As we are about to drop support for image parameters in CamereaFrame #2396

[sfegan]

The way you have drawn the length and width is confusing since it shows them as a "diameter" rather than a "radius". For example, you note that the length is 0.26m but the blue line that you indicate as the length is 0.52m in length. I would suggest you stop the blue and green lines at the center of the ellipse to avoid confusion.

[vuillaut]

Nice!

Does it also work in TelescopeFrame? As we are about to drop support for image parameters in CamereaFrame #2396

Given a few changes, yes seems to work fine

Sall I wait for #2396 to be merged?

[vuillaut]

With the latest fixes

[maxnoe]

You can see the rendered docs page here now:

https://ctapipe--2868.org.readthedocs.build/en/2868/auto_examples/visualization/hillas.html#sphx-glr-auto-examples-visualization-hillas-py

The images are very small. I think because it tries to show both images side-by-side because they come from the same "cell".

Could you split the two graphics into two cells? Or do we really need the standard camera display here?

[vuillaut]

@maxnoe thanks for the review
The 2nd plot was a leftover from a late comparison test I did sorry, I just removed it, the figure should now appear much bigger.

[vuillaut]

@maxnoe shall I switch already to TelescopeFrame()?

[maxnoe]

@maxnoe shall I switch already to TelescopeFrame()?

Yes please. TelescopeFrame is the default for a long time now. We are only talking about dropping the legacy support for CameraFrame parameters.

[ctao-sonarqube]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube