Skip to content

Fix IRF interpolation on macos #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fix IRF interpolation on macos #307

wants to merge 6 commits into from

Conversation

@maxnoe
Copy link
Member

@maxnoe maxnoe commented Aug 14, 2025

Fixes #306

@maxnoe maxnoe requested a review from HealthyPear as a code owner August 14, 2025 10:17
@maxnoe maxnoe force-pushed the fix_interpolation_macos_arm branch from c5fa3fe to 84a7146 Compare August 14, 2025 10:18
@maxnoe maxnoe requested a review from RuneDominik as a code owner August 14, 2025 10:23
@maxnoe maxnoe requested a review from kosack September 18, 2025 11:01
RuneDominik
RuneDominik approved these changes Sep 24, 2025
View reviewed changes
Copy link
Member

@RuneDominik RuneDominik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original use of long double in the type check was, as far as I rember, only done to assert that even the use of a long double as input does not break the function. Thus, the check against float_max should preserve the orginal intent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RuneDominik RuneDominik RuneDominik approved these changes

@HealthyPear HealthyPear Awaiting requested review from HealthyPear HealthyPear is a code owner

@kosack kosack Awaiting requested review from kosack

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Suggestion of replacing np.float128 with np.float64 in pyirf to support IRF interpolation on macOS

3 participants

@maxnoe @RuneDominik