Skip to content

Conversation

@mpkorstanje
Copy link
Contributor

⚡️ What's your motivation?

Fixes: #51

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

♻️ Anything particular you want feedback on?

By doing this we're exposing the public API surface. If #41 ever gets implemented, it may require a change to the AST. We can live with that.

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@mpkorstanje mpkorstanje force-pushed the make-parser-public branch from ca213e4 to 9c1a74a Compare May 15, 2025 14:12
Fixes: #51

By doing this we're exposing the public API surface. If #41 ever gets
implemented, it may require a change to the AST. We can live with that.
@mpkorstanje mpkorstanje force-pushed the make-parser-public branch from 9c1a74a to 533f709 Compare May 15, 2025 14:52
@mpkorstanje mpkorstanje requested a review from laeubi May 18, 2025 14:53
Copy link
Contributor

@laeubi laeubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mpkorstanje sorry I totally missed this to many mails from cucumber :-\

This looks great and would avoid that we need to embeds the expressions in cucumber-eclipse so +1 from my side!

@mpkorstanje mpkorstanje self-assigned this Nov 5, 2025
@mpkorstanje mpkorstanje mentioned this pull request Nov 10, 2025
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[java] provide a public method to convert a cucumber expression into parsed segments

3 participants