Remove dependency on specific gettext version #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturz
force-pushed
the
107-remove-dependency-on-specific-gettext-version
branch
8 times, most recently
from
94c4ea9 to
41561fb
Compare
arturz
force-pushed
the
107-remove-dependency-on-specific-gettext-version
branch
from
41561fb to
a26baa5
Compare
arturz
commented
Mar 12, 2025
| - Gettext 0.26.0+ | ||
| - PostgreSQL 15+ or SQLite 3.31.0+ | ||
|
|
||
| ## Installation |
There was a problem hiding this comment.
Remove note about specific gettext version requirement under the Installation section
szsoppa
reviewed
Mar 13, 2025
| alias Kanta.Utils.Compilation | ||
| defmodule Kanta.Gettext.Adapter do | ||
| @moduledoc """ | ||
| Kanta adapter used in *gettext functions from Kanta.Gettext.Macros. |
There was a problem hiding this comment.
Just wondering if *gettext shouldn't be gettext maybe?
There was a problem hiding this comment.
No, because there are a bunch of functions ending with gettext, such as ngettext, pgettext, dgettext, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #107