-
Notifications
You must be signed in to change notification settings - Fork 275
fix(actions): Fix haptic support #988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Tested on iOS. |
It doesn't seem to do anything different on Android whatever the setting (I get the default vibration) while using the Home Assistant Companion App. Isn't the action firing an event because I always get a vibration even if not set? |
Checking this out. Looks like "haptic" event is not being intercepted so the regular Frontend haptic is forwarding as well as the custom (seen in ADB debug messages for emaultor). If you try a custom action which is not toggle you will likely get the correct haptic. I will post back findings. |
Will need a different approach. Will close this PR and submit new to not have a messy commit history. |
Reopening. |
Frontend PR#27251 created to allow for capturing events at window level correctly for "haptic" event. |
This has been approved and merged to Frontend dev. |
Closes #956
Closes #565
Fixes #760