fix: Embedded light card handle issue #989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe |
|
Else could we maybe forward the event to the button-card parent using |
I think this is the best option if you don't think it will be breaking in any way. I can't see that it would be. |
|
It shouldn't break anything but you never know with those events... They give me nightmares 🤣 |
|
Updated. |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 16, 2025
## [5.0.0-dev.1](v4.3.0...v5.0.0-dev.1) (2025-09-16) ### ⚠ BREAKING CHANGES * **color:** Card background color will always be `var (--card-background-color)` when state is inactive and `color_type: card`. You can set card background with state. ### Features * Add `icon_*_action` support ([#984](#984)) ([4e02887](4e02887)), closes [#739](#739) * Support update timer ([#981](#981)) ([4717feb](4717feb)), closes [#436](#436) ### Bug Fixes * **color:** inactive card background no longer inactive color when `colour_type: card` and `color` set. ([#987](#987)) ([b4f00f9](b4f00f9)), closes [#754](#754) * Embedded light card handle issue ([#989](#989)) ([d01ef37](d01ef37)), closes [#427](#427) [#901](#901) * Hold action on picture entity ([#996](#996)) ([9f2501f](9f2501f)), closes [#994](#994) * Move while hold on touch devices ([#993](#993)) ([2c17386](2c17386))
|
🎉 This PR is included in version 5.0.0-dev.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
dcapslock
pushed a commit
to dcapslock/button-card
that referenced
this pull request
Sep 17, 2025
## [5.0.0-dev.1](custom-cards/button-card@v4.3.0...v5.0.0-dev.1) (2025-09-16) ### ⚠ BREAKING CHANGES * **color:** Card background color will always be `var (--card-background-color)` when state is inactive and `color_type: card`. You can set card background with state. ### Features * Add `icon_*_action` support ([custom-cards#984](custom-cards#984)) ([4e02887](custom-cards@4e02887)), closes [custom-cards#739](custom-cards#739) * Support update timer ([custom-cards#981](custom-cards#981)) ([4717feb](custom-cards@4717feb)), closes [custom-cards#436](custom-cards#436) ### Bug Fixes * **color:** inactive card background no longer inactive color when `colour_type: card` and `color` set. ([custom-cards#987](custom-cards#987)) ([b4f00f9](custom-cards@b4f00f9)), closes [custom-cards#754](custom-cards#754) * Embedded light card handle issue ([custom-cards#989](custom-cards#989)) ([d01ef37](custom-cards@d01ef37)), closes [custom-cards#427](custom-cards#427) [custom-cards#901](custom-cards#901) * Hold action on picture entity ([custom-cards#996](custom-cards#996)) ([9f2501f](custom-cards@9f2501f)), closes [custom-cards#994](custom-cards#994) * Move while hold on touch devices ([custom-cards#993](custom-cards#993)) ([2c17386](custom-cards@2c17386))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #427
Also will fix #901 though Honeycomb menu should use capture event is their case.
It could be that to prevent any unknown breaking change that a config option is used, but I could not think of a good name for it!