-
Notifications
You must be signed in to change notification settings - Fork 22
improve broadcast documentation #871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, a few minor changes suggested.
* Quickly developing tasks without having to | ||
:ref:`edit and reload the workflow configuration <interventions.edit-the-workflow-configuration>`. | ||
* Sending small amounts of data from task to another (e.g. file paths). | ||
* Orchestrating production workflows from an external system. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain what you mean a bit here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a minimal example, our opps broadcasts HPC reservations into the workflows.
Broadcasts can enable a higher level monitoring / control system to reconfigure Cylc workflows on the fly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK I think it might be good to say that in the docs. "Orchestrating production workflows from an external system" is going to sound intriguing to certain users, but they won't understand what it means IMO
f677aae
to
583515d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more tweaks suggested.
Expiry Point | ||
^^^^^^^^^^^^ | ||
|
||
Broadcasts are only expired after they are no longer required by tasks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Broadcasts are only expired after they are no longer required by tasks. | |
Broadcasts expire once are they are no longer required by upcoming tasks. |
"Upcoming tasks" is clearer, and more justifiable (past tasks that haven't been re-triggered yet are not yet "upcoming").
:term:`active tasks <active task>`. | ||
* The longest cycling :term:`recurrence` in the workflow. | ||
|
||
Broadcasts which are older than the oldest cycle point to contain active tasks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Broadcasts which are older than the oldest cycle point to contain active tasks | |
Broadcasts which are older than the oldest :term:`active cycle point` |
Broadcast expiry does not occur while the workflow is paused. If you want to | ||
broadcast to a historical cycle before re-running it, first pause the workflow, | ||
then trigger the tasks, then resume the workflow, e.g: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Broadcast expiry does not occur while the workflow is paused. If you want to | |
broadcast to a historical cycle before re-running it, first pause the workflow, | |
then trigger the tasks, then resume the workflow, e.g: | |
However, broadcast expiry does not occur while the workflow is paused, so | |
you can pause the workflow, do the broadcast, trigger the tasks, and then | |
resume the workflow, e.g: |
Starting the second paragraph with "However" makes it immediately clear that we have a solution to the stated problem.
Cylc Broadcast | ||
============== | ||
|
||
Cylc "Broadcasts" allow us to override task's :cylc:conf:`[runtime]` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cylc "Broadcasts" allow us to override task's :cylc:conf:`[runtime]` | |
Cylc "Broadcasts" allow us to override task :cylc:conf:`[runtime]` |
Broadcasts can also be issued from the GUI in a similar way using the | ||
"Broadcast" command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Broadcasts can also be issued from the GUI in a similar way using the | |
"Broadcast" command. | |
Broadcasts can also be issued from the GUI in a similar way by choosing | |
"Broadcast" from the task menu. |
deleted) as the workflow moves on. Otherwise they would gradually accumulate | ||
over the life of the workflow (note broadcasts are persisted when the workflow | ||
restarts). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deleted) as the workflow moves on. Otherwise they would gradually accumulate | |
over the life of the workflow (note broadcasts are persisted when the workflow | |
restarts). | |
deleted) as the workflow moves on, to avoid gradual accumulation | |
(note broadcasts are persisted when the workflow restarts). |
This arrangement has been designed such that broadcasts should always be | ||
present for the previous instance of a task in case you want to re-run it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This arrangement has been designed such that broadcasts should always be | |
present for the previous instance of a task in case you want to re-run it. | |
This is designed to keep broadcasts as far back as the previous instance | |
of each task, in case you want to re-run it. |
Improve broadcast documentation and cover the broadcast expiry change in cylc/cylc-flow#6964
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.