Skip to content

Conversation

oliver-sanders
Copy link
Member

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

* Address a code TODO to reduce the scope of a try/except to the
  individual expressions it was intended to cover
* The overzealous error catching had hidden a genuine error causing it
  to be missed for some time, see
  cylc#6314
@oliver-sanders oliver-sanders added the could be better Not exactly a bug, but not ideal. label Aug 29, 2024
@oliver-sanders oliver-sanders added this to the 8.4.0 milestone Aug 29, 2024
@oliver-sanders oliver-sanders self-assigned this Aug 29, 2024
@ColemanTom
Copy link
Contributor

This may fix #6500 although I've not tested it. I just noted you capture the error I encountered.

@oliver-sanders oliver-sanders modified the milestones: 8.4.0, 8.5.0 Nov 29, 2024
@oliver-sanders oliver-sanders modified the milestones: 8.5.0, 8.x Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
could be better Not exactly a bug, but not ideal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants