Skip to content

Conversation

MetRonnie
Copy link
Member

Supersedes MetRonnie#36

Fixes bug uncovered in #6745:

Test failure tests/functional/workflow-host-self-id/00-address.t seems to be an uncovered bug:

>>> from cylc.flow.hostuserutil import is_remote_host, get_host_ip_by_name
>>> is_remote_host(get_host_ip_by_name('localhost'))  # (127.0.0.1 loopback IP address)
True
>>> is_remote_host(get_host_ip_by_name(get_host()))  # (network-accessible IP address)
True

In other words, when [scheduling][host self-identification]method = address, is_remote_host() gives false positives.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • No dependency changes
  • Tests are included
  • Changelog entry included if this is a change that can affect users
  • No docs needed
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@MetRonnie MetRonnie added this to the 8.4.3 milestone May 8, 2025
@MetRonnie MetRonnie requested a review from oliver-sanders May 8, 2025 15:50
@MetRonnie MetRonnie self-assigned this May 8, 2025
@MetRonnie MetRonnie added the could be better Not exactly a bug, but not ideal. label May 8, 2025
@MetRonnie MetRonnie force-pushed the is-remote-host-fix branch from 1877db8 to ffbe9df Compare May 8, 2025 16:17
@MetRonnie MetRonnie marked this pull request as draft May 8, 2025 16:27
@MetRonnie MetRonnie force-pushed the is-remote-host-fix branch from ffbe9df to b7d5fd1 Compare May 8, 2025 16:27
@oliver-sanders oliver-sanders removed their request for review June 10, 2025 12:09
@MetRonnie MetRonnie modified the milestones: 8.4.3, 8.4.x Jun 13, 2025
@MetRonnie MetRonnie modified the milestones: 8.4.x, 8.x Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
could be better Not exactly a bug, but not ideal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant