tui: add estimatedFinishTime field #7005
Open
+145
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests failing - just screenshots I think. Happy to quickly review and test this tomorrow - it would make sense to get it in 8.6 to match the GUI change (although obvs not critical). |
|
Yes, non-critical. Forgot to commit the new screenshot 🤦. |
oliver-sanders
force-pushed
the
tui.add.estimated-finish-time-field
branch
from
a77214b to
3ec67d0
Compare
* Add new field. * Abstract back-compat logic to make it easier to add and maintain support for older scheduler versions.
oliver-sanders
force-pushed
the
tui.add.estimated-finish-time-field
branch
from
3ec67d0 to
18063bc
Compare
|
(FYI: the added line is covered by tests, however, codecov cannot see this as the Tui updater is running in a separate process) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nice-to-have for 8.6 if poss, but can be bumped.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).?.?.xbranch.