Skip to content

graph: suppress jobs in cycle nodes #2223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: graph-group-collapse
Choose a base branch
from
+1 −1
Open

graph: suppress jobs in cycle nodes #2223

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/views/Graph.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
>
<GraphNode
:task="node"
:jobs="node.children"
:jobs="['task', 'family'].includes(node.type) ? node.children : []"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue was about both cycles and families displaying their children as jobs, but this only fixes it for cycles. At the moment a family could still display its tasks or child families as jobs

:jobTheme="jobTheme"
:class="{ 'flow-none': isFlowNone(node.node.flowNums) }"
/>
Expand Down