Lumino tab titles - distinguish between log view tabs #2290
+29
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MetRonnie
changed the title
MetRonnie
force-pushed
the
lumino-tab-titles
branch
from
ac713cf to
25b272e
Compare
wxtim
reviewed
Sep 17, 2025
| eventBus.emit( | ||
| `lumino:update-tab:${this.widgetID}`, | ||
| { | ||
| title: this.jobLog ? 'Log – Job' : 'Log – Workflow', |
There was a problem hiding this comment.
Consider using fewer and narrower chars?
Suggested change
| title: this.jobLog ? 'Log – Job' : 'Log – Workflow', | |
| title: this.jobLog ? 'Log: Job' : 'Log: Workflow', |
wxtim
approved these changes
Sep 17, 2025
| async ({ id, file }, old) => { | ||
| // update the widget tab caption when the id or file change | ||
| if (this.widgetID) { | ||
| const prefix = this.relativeID ? `${this.relativeID} – ` : '' |
There was a problem hiding this comment.
Why not make this simpler (Though you might also wish or add the submit number?)
Suggested change
| const prefix = this.relativeID ? `${this.relativeID} – ` : '' | |
| const prefix = this.relativeID ? `${this.relativeID}/` : '' |
There was a problem hiding this comment.
I feel like it's visually clearer to have the separation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2023
Distinguish between job and workflow log tabs in the tab title, and add a caption that shows the open file. It would be good to include that in the tab title but we would need to figure out how to truncate well.
Also increased the width of the tabs and reduced the font size slightly to accommodate the longer length of "Log − Workflow" as a title
Checklist
CONTRIBUTING.mdand added my name as a Code Contributor.