Skip to content

Conversation

MetRonnie
Copy link
Member

Bug

image

Results in nothing happening and this error:

TypeError: Cannot read properties of null (reading 'length')

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry not included as minor
  • Docs not needed

@MetRonnie MetRonnie added this to the 2.10.0 milestone Sep 8, 2025
@MetRonnie MetRonnie self-assigned this Sep 8, 2025
@MetRonnie MetRonnie added bug Something isn't working small labels Sep 8, 2025
Comment on lines 87 to 91
this.modelValue.unshift(newInput)
this.model.unshift(newInput)
Copy link
Member Author

@MetRonnie MetRonnie Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixins did not make it fun to figure out where modelValue is coming from, but it's here:

props: {
// the GraphQL type this input represents
gqlType: {
type: Object,
required: true
},
// array of all GraphQL types in the schema
types: {
type: Array,
default: () => []
},
// the value (v-model is actually syntactic sugar for this)
modelValue: {
required: true
}

We shouldn't be mutating the prop, instead we should be using the model getter/setter

Replace mixin with composables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant