Skip to content

qos: disable dynamic replica reduction #7888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 10.2
Choose a base branch
from
Open

qos: disable dynamic replica reduction #7888

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions ...cache-qos/src/main/java/org/dcache/qos/services/verifier/handlers/FileStatusVerifier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
import org.dcache.cells.CellStub;
import org.dcache.qos.data.FileQoSRequirements;
import org.dcache.qos.data.QoSAction;
import org.dcache.qos.data.QoSMessageType;
import org.dcache.qos.services.verifier.data.PoolInfoMap;
import org.dcache.qos.services.verifier.data.VerifiedLocations;
import org.dcache.qos.services.verifier.data.VerifyOperation;
Expand Down Expand Up @@ -449,6 +450,18 @@ private Optional<QoSAction> checkForLocationAdjustment(FileQoSRequirements requi
}
}

// REVISIT: effectively disable adjustment if we need to reduce the number of replicas.
//
// This section is added due to race condition between PIN and UNPIN operations, which
// may lead to PIN and UNPIN requests processed out of order. Thus UNPIN, followed by PIN, with
// expected result in file being pinned may be processed as PIN followed by UNPIN, with
// file ending in unpinned state.
//
// The redundant pinned copy will be reduced by scanner at the next run.
if (missing < 0 && operation.getMessageType() != QoSMessageType.SYSTEM_SCAN) {
missing = 0;
}

operation.setNeeded(Math.abs(missing));

LOGGER.debug("{}, checkForLocationAdjustment; required {}, excluded {}, missing {}.",
Expand Down