Skip to content

refactor: ignore campaigns that are not found #3192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor: ignore campaigns that are not found #3192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61f9365
refactor: ignore campaigns that are not found
sshanzel Oct 3, 2025
4970155
revert: unnecessary change
sshanzel Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/workers/campaignUpdatedAction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import {
type CampaignUpdateEventArgs,
} from '../common/campaign/common';
import { usdToCores } from '../common/number';
import { logger } from '../logger';
import type { TypeORMQueryFailedError } from '../errors';

interface HandlerEventArgs {
Expand Down Expand Up @@ -68,9 +67,6 @@ const worker: TypedWorker<'skadi.v2.campaign-updated'> = {
const err = originalError as TypeORMQueryFailedError;

if (err?.name === 'EntityNotFoundError') {
// some campaigns do not exist on API so just warn in case we need to check later
logger.warn({ err, params }, 'could not find campaign');

return;
}

Expand Down
3 changes: 0 additions & 3 deletions src/workers/campaignUpdatedSlack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,6 @@ const worker: TypedWorker<'skadi.v2.campaign-updated'> = {
const err = originalError as TypeORMQueryFailedError;

if (err?.name === 'EntityNotFoundError') {
// some campaigns do not exist on API so just warn in case we need to check later
logger.warn({ err, params }, 'could not find campaign');

return;
}

Expand Down
4 changes: 0 additions & 4 deletions src/workers/notifications/campaignUpdatedAction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import {
} from '../../common/campaign/common';
import { CampaignType } from '../../entity/campaign/Campaign';
import { type DataSource } from 'typeorm';
import { logger } from '../../logger';
import type { TypeORMQueryFailedError } from '../../errors';

const worker: TypedNotificationWorker<'skadi.v2.campaign-updated'> = {
Expand Down Expand Up @@ -44,9 +43,6 @@ const worker: TypedNotificationWorker<'skadi.v2.campaign-updated'> = {
const err = originalError as TypeORMQueryFailedError;

if (err?.name === 'EntityNotFoundError') {
// some campaigns do not exist on API so just warn in case we need to check later
logger.warn({ err, params }, 'could not find campaign');

Comment on lines -47 to -49
Copy link
Contributor

@capJavert capJavert Oct 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we removing the logs?

The issue Chris reported was that the worker is retrying and logs have nothing to do with it. They just early return and ack the message.

return;
}

Expand Down
Loading