reduce boilerplate implementing comparisons for user-defined types #99
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In signalapp/libsignal#469, we discussed having to hand-roll a constant-time comparison function for a public key with a slice of bytes and an enum tag. After seeing #78 where we implement
ConstantTimeEqfor slices, I realized we could extend this method of iterated constant-time computation to make it more fluent to implement comparison operations for structs with multiple fields.Proposed Solution
IteratedOperationandIteratedEqto modularize the approach used in the existingConstantTimeEqimpl for slices.ConstantTimeGreaterover a collection of elements asLexicographicIteratedGreater.ConstantTimeGreaterfor slices usingLexicographicIteratedGreater.Result
ConstantTimeOrdwill be implemented automatically for slices if/when define and implementConstantTime{Partial,}Ordtraits #98 is merged.