Skip to content

Conversation

jcfr
Copy link
Contributor

@jcfr jcfr commented Aug 28, 2025

This pull request reformats the codebase using astyle 3.0.1 to ensure consistency with the project’s current style guidelines.

Context

As noted in the review (#508 (comment)), the long-term plan is to transition formatting to uncrustify (likely by adapting the runformat script from the cppcheck repo). While that transition is being worked out, this change helps keep the repository consistent and avoids confusion for contributors.

This change applies code formatting to the source files using astyle version
3.0.1 according to the project's style guidelines.

Changes are purely stylistic with no functional modifications.
@jcfr
Copy link
Contributor Author

jcfr commented Aug 28, 2025

cc: @danmar

@danmar
Copy link
Owner

danmar commented Aug 28, 2025

This pull request reformats the codebase using astyle 3.0.1 to ensure consistency with the project’s current style guidelines.

it just creates extra stylistic changes in the git log. when we move to uncrustify we'll probably need to do something like this again.

@danmar danmar closed this Aug 28, 2025
@jcfr jcfr deleted the astyle-3.0.1-format branch August 28, 2025 16:42
@jcfr
Copy link
Contributor Author

jcfr commented Aug 28, 2025

Thanks for taking the time to follow up 🙏

Looking forward to the improved code formatting infrastructure.

If possible consider:

  • adding a pre-commit.yml GitHub workflow
  • adding .git-blame-ignore-revs to ensure the stylistic changes do not pollute the history
  • (ideally) having the corresponding binary available through tooling like uvx or pipx.

it just creates extra stylistic changes in the git log.

I should have specified that this type of changes should be added to .git-blame-ignore-revs to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants