Skip to content

Conversation

ofek
Copy link

@ofek ofek commented Mar 8, 2025

This upgrades coincurve to v21.0.0 which brings performance improvements and removes all runtime dependencies!

@ofek ofek mentioned this pull request Mar 8, 2025
@darosior
Copy link
Owner

Thanks! Unfortunately CI is now failing on Coincurve installation:

Installed /opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/bip32-4.0-py3.8.egg
Processing dependencies for bip32==4.0
Searching for coincurve<22,>=15.0
Reading https://pypi.org/simple/coincurve/
Downloading https://files.pythonhosted.org/packages/6f/a2/f2a38eb05b747ed3e54e1be33be339d4a14c1f5cc6a6e2b342b5e8160d51/coincurve-21.0.0.tar.gz#sha256=8b37ce4265a82bebf0e796e21a769e56fdbf8420411ccbe3fafee4ed75b6a6e5
Best match: coincurve 21.0.0
Processing coincurve-21.0.0.tar.gz
error: Couldn't find a setup script in /tmp/easy_install-shrrtm46/coincurve-21.0.0.tar.gz
Error: Process completed with exit code 1.

@ofek
Copy link
Author

ofek commented Mar 10, 2025

I can make CI pass if you want but how long do you plan to support 3.8?

@darosior
Copy link
Owner

I don't think this is related to 3.8. It also fails on the 3.10 job, and i suspect it would fail on all of them given enough time.

@ofek
Copy link
Author

ofek commented Mar 11, 2025

I think I found the issue, can you please run CI once more?

The Python packaging ecosystem has standardized on the interface for build backends (PEP 517/PEP 660) and the format for metadata declaration (PEP 621/PEP 631). As a result, the execution of setup.py files is now deprecated.

@darosior
Copy link
Owner

Unfortunate that the CI doesn't run automatically anymore, just kicked it let's see.

@ofek
Copy link
Author

ofek commented Mar 12, 2025

Yay all green now!

@darosior
Copy link
Owner

Hi, just letting you know i did not forget about this.

@dni
Copy link

dni commented Apr 2, 2025

bump :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants