Skip to content

Conversation

thephez
Copy link
Collaborator

@thephez thephez commented Sep 16, 2025

Issue being fixed or feature implemented

Just a few grammar/formatting adjustments

What was done?

Grammar / whitespace changes

How Has This Been Tested?

Built locally

Breaking Changes

N/A

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

Copy link

✅ No Merge Conflicts Detected

This PR currently has no conflicts with other open PRs.

Copy link

coderabbitai bot commented Sep 16, 2025

Walkthrough

String literals in governance RPC error messages were adjusted in src/rpc/governance.cpp. Specifically, gobject_check, gobject_prepare, and gobject_submit now include a space after the colon in "Invalid proposal data, error messages: ". In vote-related paths (gobject_vote_many, gobject_vote_alias, voteraw), the text "Please using one of the following: " was corrected to "Please use one of the following: ". No control flow, signatures, or APIs changed; only message text/formatting was modified.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title "chore: minor rpc typo fixes" is concise and directly summarizes the main change (minor grammar/formatting fixes in RPC code), making it clear and relevant for repository history and reviewers.
Description Check ✅ Passed The PR description clearly states the intent (grammar/whitespace fixes), notes testing (built locally), and indicates no breaking changes, which aligns with the provided changeset and is not off-topic.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 893b46a and e899ffd.

📒 Files selected for processing (1)
  • src/rpc/governance.cpp (6 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
src/**/*.{cpp,h,cc,cxx,hpp}

📄 CodeRabbit inference engine (CLAUDE.md)

src/**/*.{cpp,h,cc,cxx,hpp}: Dash Core C++ codebase must be written in C++20 and require at least Clang 16 or GCC 11.1
Dash uses unordered_lru_cache for efficient caching with LRU eviction

Files:

  • src/rpc/governance.cpp
🧬 Code graph analysis (1)
src/rpc/governance.cpp (1)
src/rpc/request.cpp (2)
  • JSONRPCError (56-62)
  • JSONRPCError (56-56)
🪛 GitHub Actions: Clang Diff Format Check
src/rpc/governance.cpp

[error] 114-914: Clang-format differences detected in governance.cpp. Formatting changes detected by clang-format-diff (wraps long JSONRPCError messages across lines). The failing CI step was the clang-format check: 'git diff -U0 origin/develop -- $(git ls-files -- $(cat test/util/data/non-backported.txt)) | ./contrib/devtools/clang-format-diff.py -p1 > diff_output.txt'.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Build container / Build container
  • GitHub Check: Build slim container / Build container
🔇 Additional comments (7)
src/rpc/governance.cpp (7)

117-117: Grammar/spacing tweak LGTM.

Message reads naturally; change is correct.


188-188: Grammar/spacing tweak LGTM.

Consistent with other proposal validation errors.


365-365: Grammar/spacing tweak LGTM.

Matches the wording used in prepare/check paths.


513-515: “Please use …” correction LGTM.

Improves clarity; list formatting remains consistent with adjacent messages.


566-568: “Please use …” correction LGTM.

Same fix as vote-many; consistent wording.


917-919: “Please use …” correction LGTM.

Consistent across vote-related RPCs.


114-914: Run clang-format on src/rpc/governance.cpp to fix CI failure

CI reports clang-format differences — reflow long JSONRPCError arguments (wrap/split long throw(...) argument strings so the message argument is on its own line). Verification attempt failed: clang-format not available in the environment (clang-format: command not found) — run the repository clang-format locally and commit the formatted changes.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK e899ffd

@UdjinM6 UdjinM6 added this to the 23 milestone Sep 17, 2025
Copy link
Collaborator

@knst knst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK e899ffd

Copy link
Collaborator

@kwvg kwvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK e899ffd

@PastaPastaPasta PastaPastaPasta merged commit d9ff98c into dashpay:develop Sep 23, 2025
32 of 36 checks passed
@thephez thephez deleted the v23-trivial-rpc branch September 23, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants