-
Notifications
You must be signed in to change notification settings - Fork 1.2k
chore: minor rpc typo fixes #6850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ No Merge Conflicts DetectedThis PR currently has no conflicts with other open PRs. |
WalkthroughString literals in governance RPC error messages were adjusted in src/rpc/governance.cpp. Specifically, gobject_check, gobject_prepare, and gobject_submit now include a space after the colon in "Invalid proposal data, error messages: ". In vote-related paths (gobject_vote_many, gobject_vote_alias, voteraw), the text "Please using one of the following: " was corrected to "Please use one of the following: ". No control flow, signatures, or APIs changed; only message text/formatting was modified. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (1)src/**/*.{cpp,h,cc,cxx,hpp}📄 CodeRabbit inference engine (CLAUDE.md)
Files:
🧬 Code graph analysis (1)src/rpc/governance.cpp (1)
🪛 GitHub Actions: Clang Diff Format Checksrc/rpc/governance.cpp[error] 114-914: Clang-format differences detected in governance.cpp. Formatting changes detected by clang-format-diff (wraps long JSONRPCError messages across lines). The failing CI step was the clang-format check: 'git diff -U0 origin/develop -- ⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (7)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal). Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK e899ffd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK e899ffd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK e899ffd
Issue being fixed or feature implemented
Just a few grammar/formatting adjustments
What was done?
Grammar / whitespace changes
How Has This Been Tested?
Built locally
Breaking Changes
N/A
Checklist:
Go over all the following points, and put an
x
in all the boxes that apply.