Adding workspace infra state migration to Terraform templates for AWS, GCP, and Azure for the blogathon #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eri-adepoju
requested review from
kwulffert23,
matthewmoorcroft,
anupkalburgi,
QuentinAmbard,
alanreese-dbrx and
srinivasadmala
as code owners
|
can you get someone to review & comment here @eri-adepoju ? |
alexott
requested changes
Apr 23, 2025
Comment on lines
12
to
15
| terraform import databricks_mws_credentials.this "${databricks_account_id}/${credentials_id}" | ||
| terraform import databricks_mws_networks.this "${databricks_account_id}/${network_id}" | ||
| terraform import databricks_mws_storage_configurations.this "${databricks_account_id}/${storage_configuration_id}" | ||
| terraform import databricks_mws_workspaces.this "${databricks_account_id}/${workspace_id}" |
There was a problem hiding this comment.
use import blocks instead of shell script
Comment on lines
8
to
10
| terraform import azurerm_databricks_workspace.this "${azure_workspace_resource_id}" | ||
| terraform import azurerm_subnet_nat_gateway_association.private "${private_subnet_resource_id}" | ||
| terraform import azurerm_subnet_nat_gateway_association.public "${public_subnet_resource_id}" |
|
@eri-adepoju what is the status on Alex's comments |
Hello! I've updated the code with the requested changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have read and followed the contribution guidelines. Here is the draft of the blog post: https://docs.google.com/document/d/1G5FdT57U_kdCpxySdNa8AnTUrjGMnV9fBxnwymTmYW0/edit?tab=t.0, currently searching for SME Reviewer.