Add setup for DBR testing #3557
Open
+304
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
commented
Sep 7, 2025
| // If the test is being run on DBR, auth is already configured | ||
| // by the dbr_runner notebook by reading a token from the notebook context and | ||
| // setting DATABRICKS_TOKEN and DATABRICKS_HOST environment variables. | ||
| _, _, tmpDir = workspaceTmpDir(t.Context(), t) |
There was a problem hiding this comment.
This was necesary to ensure the test directory gets cleaned up. Otherwise the context seems to be cancelled before t.Cleanup is executed.
There was a problem hiding this comment.
The doc for testing.T.Context says as much: https://pkg.go.dev/testing#T.Context
Unless there is another context to use, it seems better to use context.Background() in the cleanup function directly, or other call sites will be prone to the same error.
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
10 failing tests:
|
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
requested review from
pietern,
andrewnester,
denik and
anton-107
as code owners
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
reviewed
Sep 10, 2025
pietern
reviewed
Sep 11, 2025
| // If the test is being run on DBR, auth is already configured | ||
| // by the dbr_runner notebook by reading a token from the notebook context and | ||
| // setting DATABRICKS_TOKEN and DATABRICKS_HOST environment variables. | ||
| _, _, tmpDir = workspaceTmpDir(t.Context(), t) |
There was a problem hiding this comment.
The doc for testing.T.Context says as much: https://pkg.go.dev/testing#T.Context
Unless there is another context to use, it seems better to use context.Background() in the cleanup function directly, or other call sites will be prone to the same error.
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds a notebook we can use to easily run and iterate on DBR tests.
Why
Simplifies the test setup and makes it easy to debug issues with the DBR testing framework itself. You just have to run
make dbr_scratchto get started.