Skip to content

Conversation

amlaenxc
Copy link

@amlaenxc amlaenxc commented Apr 2, 2025

If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.
Closes #316

Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.
Simplified the changes to the descriptions of the data types in SQLite, since SQLite & the DB Browser for SQLite only use these data types anyway. Though, I don't believe the discussion in #316 was quite correct about exactly what the data types are, and went by the documentation for SQLite: https://www.sqlite.org/datatype3.html

If any relevant discussions have taken place elsewhere, please provide links to these.

For more guidance on how to contribute changes to a Carpentries project, please review the Contributing Guide and Code of Conduct.

Please keep in mind that lesson Maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at [email protected].

Copy link

github-actions bot commented Apr 2, 2025

🆗 Pre-flight checks passed 😃

This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits.

It should be safe to Approve and Run the workflows that need maintainer approval.

Copy link
Contributor

@adamancer adamancer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @amlaenxc! Thanks for this pull request! I agree that including data types that do not appear in SQLite is confusing, and this seems like a good change to simplify the lesson a bit. I put a few suggestions here, let me know if you have any thoughts about them.

| NUMERIC(p,s) | Exact numerical, precision p, scale s. (Same as DECIMAL) |
| FLOAT(p) | Approximate numerical, mantissa precision p. A floating number in base 10 exponential notation. |
| TEXT | Character string |
| BLOB | Raw binary data |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not count on learners knowing what binary data is. You might include examples (image file, etc.)

Is BLOB in SQLite always binary? That's generally what BLOB implies but the definition here suggests the BLOB format just stores the data as is.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not exactly sure what the documentation means for the BLOB datatype with regards to whether it is always stored as raw binary. In any case, I updated the description in the table to avoid referencing "binary data" and hopefully be more understandable.

| MULTISET | A variable-length and unordered collection of elements |
| XML | Stores XML data |

### SQL Data Type Quick Reference {#datatypediffs}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that the quick reference table is a lot for the lesson but would like to retain this in learners/sql-cheat-sheet.md.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've moved that quick reference table to learners/sql-cheat-sheet.md, and added a column for SQLite since that is the main database platform used in this workshop.

@amlaenxc
Copy link
Author

amlaenxc commented Apr 22, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

review SQL data types
2 participants