Skip to content

fix(ingest/bigquery): Fix bigquery user agent string #15214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(ingest/bigquery): Fix bigquery user agent string #15214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions metadata-ingestion/src/datahub/ingestion/source/bigquery_v2/bigquery_connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,12 @@


def _get_bigquery_client_info() -> ClientInfo:
"""Get ClientInfo with DataHub user-agent for BigQuery client identification"""
return ClientInfo(user_agent=f"datahub/{__version__}")
"""Get ClientInfo with DataHub user-agent for GCP API identification.

Follows Google's recommended format:
"<prod_name>/ver (GPN:<company name>; <other comments>)"
"""
return ClientInfo(user_agent=f"DataHub/{__version__} (GPN:DataHub)")


class BigQueryConnectionConfig(ConfigModel):
Expand Down Expand Up @@ -68,9 +72,15 @@ def make_gcp_logging_client(
client_options = self.extra_client_options.copy()
client_options["_use_grpc"] = False
if project_id is not None:
return GCPLoggingClient(**client_options, project=project_id)
return GCPLoggingClient(
**client_options,
project=project_id,
client_info=_get_bigquery_client_info(),
)
else:
return GCPLoggingClient(**client_options)
return GCPLoggingClient(
**client_options, client_info=_get_bigquery_client_info()
)

def get_sql_alchemy_url(self) -> str:
if self.project_on_behalf:
Expand Down
Loading