Skip to content

Conversation

michaelsembwever
Copy link
Member

https://github.com/riptano/cndb/issues/15580

Port into main-5.0 commit 243ca72

CNDB-15519 test BM25 after compaction too (https://github.com/datastax/cassandra/pull/2026)
Compaction might write SAI differently than flush, thus it's good to
have tests running after compaction.

Changes to use runThenFlushThenCompact instead of beforeAndAfterFlush in
BM25 test. Another test already tests after compaction in addition to
memtable and after flush.

Copy link

github-actions bot commented Oct 9, 2025

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

Compaction might write SAI differently than flush, thus it's good to
have tests running after compaction.

Changes to use runThenFlushThenCompact instead of beforeAndAfterFlush in
BM25 test. Another test already tests after compaction in addition to
memtable and after flush.
Copy link

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-2049 rejected by Butler


3 regressions found
See build details here


Found 3 new test failures

Test Explanation Runs Upstream
o.a.c.cql3.validation.operations.AggregationQueriesTest.testAggregationQueryShouldNotTimeoutWhenItExceedesReadTimeout (compression) REGRESSION 🔴🔴 2 / 10
o.a.c.index.sai.disk.v2.sortedterms.SortedTermsTest.testFileValidation (compression) REGRESSION 🔴🔵 0 / 10
o.a.c.nodes.NodesPersistenceTest.testUpdateTokens (compression) REGRESSION 🔴🔵 0 / 10

Found 5 known test failures

Copy link

@djatnieks djatnieks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The NodePersistenceTest and SortedTermsTest failures in the CI build pass locally for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants