Skip to content

Conversation

michaelsembwever
Copy link
Member

https://github.com/riptano/cndb/issues/15631

Port into main-5.0 commit d6c7b59

CNDB-8641: Add a metric to count all request errors (https://github.com/datastax/cassandra/pull/1983)
### What is the issue

https://github.com/riptano/cndb/issues/8641

PR in CNDB: https://github.com/riptano/cndb/pull/15306

### What does this PR fix and why was it fixed

This pull request introduces new metrics for tracking invalid and other
error requests for CQL statements, and integrates these metrics into the
query failure notification logic. The main changes are the addition of
the `AllRequestsMetrics` class, updates to the `ClientRequestsMetrics`
class to include these new metrics, and modifications to the query event
notification methods to record errors using the new metrics.

Metrics added:
* org.apache.cassandra.metrics.ClientRequest.Timeouts.All
* org.apache.cassandra.metrics.ClientRequest.Unavailables.All
* org.apache.cassandra.metrics.ClientRequest.Failures.All
* org.apache.cassandra.metrics.ClientRequest.Invalid.All
* org.apache.cassandra.metrics.ClientRequest.OtherErrors.All

 Note: only requests for which a tenant can be identified are counted.

Copy link

github-actions bot commented Oct 9, 2025

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

### What is the issue

riptano/cndb#8641

PR in CNDB: riptano/cndb#15306

### What does this PR fix and why was it fixed

This pull request introduces new metrics for tracking invalid and other
error requests for CQL statements, and integrates these metrics into the
query failure notification logic. The main changes are the addition of
the `AllRequestsMetrics` class, updates to the `ClientRequestsMetrics`
class to include these new metrics, and modifications to the query event
notification methods to record errors using the new metrics.

Metrics added:
* org.apache.cassandra.metrics.ClientRequest.Timeouts.All
* org.apache.cassandra.metrics.ClientRequest.Unavailables.All
* org.apache.cassandra.metrics.ClientRequest.Failures.All
* org.apache.cassandra.metrics.ClientRequest.Invalid.All
* org.apache.cassandra.metrics.ClientRequest.OtherErrors.All

 Note: only requests for which a tenant can be identified are counted.
Copy link

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-2055 rejected by Butler


5 regressions found
See build details here


Found 5 new test failures

Test Explanation Runs Upstream
o.a.c.cql3.validation.operations.AggregationQueriesTest.testAggregationQueryShouldNotTimeoutWhenItExceedesReadTimeout (compression) REGRESSION 🔴🔴 2 / 10
o.a.c.distributed.test.hostreplacement.HostReplacementTest.replaceAliveHost REGRESSION 🔵🔴 0 / 10
o.a.c.distributed.test.hostreplacement.HostReplacementTest.replaceDownedHost REGRESSION 🔵🔴 0 / 10
o.a.c.distributed.test.hostreplacement.HostReplacementTest.retryingFailedReplaceWithNodeInHibernateState REGRESSION 🔵🔴 0 / 10
o.a.c.distributed.test.hostreplacement.HostReplacementTest.seedGoesDownBeforeDownHost REGRESSION 🔵🔴 0 / 10

Found 6 known test failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants