Skip to content

Conversation

michaelsembwever
Copy link
Member

https://github.com/riptano/cndb/issues/15577

Port into main-5.0 commit 748018e

CNDB-14650: allow mixed mode repair

Copy link

github-actions bot commented Oct 9, 2025

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
75.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-2058 rejected by Butler


2 regressions found
See build details here


Found 2 new test failures

Test Explanation Runs Upstream
replica_side_filtering_test.TestAllowFiltering.test_update_on_static_column_with_not_empty_partition (offheap-bti) REGRESSION 🔴 0 / 10
o.a.c.index.sai.cql.VectorLocalTest.randomizedBqCompressedTest[dc] (compression) REGRESSION 🔴 0 / 10

Found 5 known test failures

Copy link

@djatnieks djatnieks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VectorLocalTest passes locally for me and I can't get DTEST replica_side_filtering_test.TestAllowFiltering.test_update_on_static_column_with_not_empty_partition to pass locally with main either** - maybe double check that @michaelsembwever ?

** it complains about 127.0.02 being down which usually means needing sudo ifconfig lo0 alias 127.0.0.2 up on a Mac but I have done that already. 🤷🏻

@michaelsembwever
Copy link
Member Author

michaelsembwever commented Oct 15, 2025

I can't get DTEST replica_side_filtering_test.TestAllowFiltering.test_update_on_static_column_with_not_empty_partition to pass locally…

@djatnieks ,

Easiest done in docker like:

.build/docker/run-tests.sh -a dtest -t test_update_on_static_column_with_not_empty_partition

it passes locally for me.

@michaelsembwever michaelsembwever merged commit 2ae72a1 into main-5.0 Oct 15, 2025
572 of 589 checks passed
@michaelsembwever michaelsembwever deleted the mck-cndb-15577-main-5.0 branch October 15, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants