-
Notifications
You must be signed in to change notification settings - Fork 139
Vectordata streaming support for examples/bench [Updated] #540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jshook
wants to merge
30
commits into
main
Choose a base branch
from
jshook/streamer-07
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merged complimentary logic between branches
|
Before you submit for review:
If you did not complete any of these, then please explain below. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the examples/bench capabilities in jvector:
The DataSet type is virtualized behind an interface
The way DataSets are loaded is more modular
A DataSet loader has been added to support the vectordata API
The net effect is that bench can no access vectordata hosted datasets.
The benefits of this are several:
remote vector test data hosting
uniform API for finding and using vector datasets
merkle-based automatic download of chunks for dynamic access
efficient download and automatic caching of data locally on test nodes
mapping and ranging subsets of data, such as "first 1M", "first 10M" and so on under profile names
packing various vector data views in a consistent API: base, query, ...
management of datasets via catalogs, orthogonal to access control
Most of the core wiring of these capabilities is provided by another library which is part of the nosqlbench project. The changes to jvector are to adapt it to use these APIs.
There are a couple issues yet to resolve with the Java version configs and GHA.