Skip to content

Conversation

@michaeljmarshall
Copy link
Member

@michaeljmarshall michaeljmarshall commented Oct 22, 2025

This PR is meant to show an alternative to #554. The main idea is that we already have a mapping class, and if the caller wants to remap values, they can do it on their own. The primary benefit of this change is that is backwards compatible, while #554 is not.

@github-actions
Copy link
Contributor

Before you submit for review:

  • Does your PR follow guidelines from CONTRIBUTIONS.md?
  • Did you summarize what this PR does clearly and concisely?
  • Did you include performance data for changes which may be performance impacting?
  • Did you include useful docs for any user-facing changes or features?
  • Did you include useful javadocs for developer oriented changes, explaining new concepts or key changes?
  • Did you trigger and review regression testing results against the base branch via Run Bench Main?
  • Did you adhere to the code formatting guidelines (TBD)
  • Did you group your changes for easy review, providing meaningful descriptions for each commit?
  • Did you ensure that all files contain the correct copyright header?

If you did not complete any of these, then please explain below.

Copy link
Contributor

@marianotepper marianotepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an improvement over the alternative #554

@marianotepper
Copy link
Contributor

@sam-herman please take a look at this PR. As it is an improvement over #536 and over the alternative #554

Copy link
Contributor

@MarkWolters MarkWolters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marianotepper marianotepper merged commit a1f05ea into main Oct 22, 2025
10 of 11 checks passed
@marianotepper marianotepper deleted the fix-random-access-score-provider branch October 22, 2025 21:00
@sam-herman
Copy link
Contributor

@sam-herman please take a look at this PR. As it is an improvement over #536 and over the alternative #554

Thanks for the heads up! LGTM as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants