Refactored #35
Open
Refactored #35
+28
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }; | ||
|
|
||
| // Resizer() resizes items based on the object width divided by the compressor * 10 | ||
| function resizer (self, settings) { |
There was a problem hiding this comment.
I factored this out of the plugin execution so that it doesn't need to be defined each time the plugin is called.
|
Does this mean |
|
No, defaults isn't in the global scope. It is in the function/closure scope where the plugin is the only code that can access it. This way that value isn't re-evaluated each time the plugin is executed only once per page load. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just saw you on CSS Summit today. I love the small library philosophy for JavaScript. Anyway I wanted to send you my two cents on fittext just in case you were looking for any collaboration. If not, I at least got to understand your code a little more. Keep on rockin out with the small JS libs.