Changes coffee to js, gives display name to bot core, exports matrix client so bot plugins can access it #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so include the display name so that the bot will respond with your display name.
davidar
requested changes
Jun 13, 2017
src/matrix.js
Outdated
| let prettyname = room.currentState._userIdsToDisplayNames[name]; | ||
| let user = this.robot.brain.userForId(name, { name: prettyname }); | ||
| user.room = room.roomId; | ||
| if (user.name !== this.user_id) { |
Owner
There was a problem hiding this comment.
Change user.name to user.id here
Contributor
Author
There was a problem hiding this comment.
good catch, I just updated this and also gave it name flexibility so it's displayname/botname can be different from it's matrix id
davidar
approved these changes
Jun 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does 3 things
robot.matrixClient = clientso that plugins can do advanced things specific to matrix. For example create an unfederated room.