Fix asyncio.gather to wait for process to finish #1246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify TikTokApi to use session injection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using create session with multiple sessions, an asynchronous task is created in order to create these sessions. However, the default behavior is to immediately exit out if there is any error in creating the session. This behavior leaves behind dangling tasks not tracked by the caller, creating cases where more sessions are created than wanted when put into a while loop. This is more evident when using proxies and there are alot of cases where multiple __create_session can fail. As a result, I added a return_exceptions=True so that it would wait until all tasks are considered done