-
Notifications
You must be signed in to change notification settings - Fork 23
chore: add retry functionality in the systemDb connection #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you push again with the deleted .idea folder?
Done thanks : ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AayushSaini101 We also need to cover retries to DB interruptions in steps and other DBOS operations too
@AayushSaini101 Thanks for the contribution! As @af-md mentioned, what #93 means to fix is resilience flacky DB connections when performing DBOS durability features. Here's an example:
What we need is being able to detect that the error falls into the category of (retriable DB errors) and do the retry. To do this we'd first see if the error is of type
For this enhancement, it would be worth exploring this library: https://github.com/avast/retry-go. Specifically if we could wrap the retry logic inside We'll also need a good amount of testing, which we can do using https://github.com/Shopify/toxiproxy |
closes : #93