feat: enhance validation error messages for ADR-45 and ADR-173 compliance #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…larity and compliance with ADR-173
Test this pull request
|
Co-authored-by: Lautaro Petaccio <[email protected]> Signed-off-by: Andrés Morelos <[email protected]>
Co-authored-by: Lautaro Petaccio <[email protected]> Signed-off-by: Andrés Morelos <[email protected]>
…ve clarity and consistency
aleortega
approved these changes
Oct 6, 2025
src/validations/ADR45.ts
Outdated
| if (entityIsNotVersion3(entity) && entityWasDeployedAfterADR45(entity)) | ||
| return validationFailed('Only entities v3 are allowed after ADR-45') | ||
| return validationFailed( | ||
| 'Upload failed: only entities v3 are allowed after the ADR-45. Check http://adr.decentraland.org/adr/ADR-45 for more information' |
There was a problem hiding this comment.
Suggested change
| 'Upload failed: only entities v3 are allowed after the ADR-45. Check http://adr.decentraland.org/adr/ADR-45 for more information' | |
| 'Only entities v3 are allowed after the ADR-45. Check http://adr.decentraland.org/adr/ADR-45 for more information' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #20